Messages in this thread | | | Date | Mon, 14 Jan 2008 15:00:14 +0800 | From | "Dave Young" <> | Subject | Re: [PATCH 1/7] driver-core : add class iteration api |
| |
On Jan 14, 2008 2:58 PM, Jarek Poplawski <jarkao2@gmail.com> wrote: > On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote: > > On Jan 13, 2008 4:11 AM, Jarek Poplawski <jarkao2@gmail.com> wrote: > ... > > > Probably some tiny oversight, but I see this comment to struct class > > > doesn't mention devices list, so maybe this needs to be updated BTW?: > > > > > > (from include/linux/device.h) > > > " struct semaphore sem; /* locks both the children and interfaces lists */" > > > > Sorry for my lazy, I think so too. > > IMHO, it should be updated after the comments. > > As a matter of fact, only later I've found this question is 'fixed' in > 7/7. But, actually, I was more concerned if this patch changed the > 'official' policy of this sem (then it would be nice to mention about > this in a changelog) or this comment was simply incomplete.
It was just "killed" because I thought it's not true.
I means I will update the correct comment after comments.
> > Thanks, > Jarek P. >
| |