Messages in this thread | | | Subject | Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in | From | Benjamin Herrenschmidt <> | Date | Sun, 13 Jan 2008 18:08:05 +1100 |
| |
On Sat, 2008-01-12 at 17:40 +0300, Ivan Kokshaysky wrote: > > Actually I'm strongly against Arjan's patch. First, it's based on > assumption that the MMCONFIG thing is sort of fundamentally broken > on some systems, but none of the facts we have so far does confirm > that. > And second, I really don't like the implementation as it breaks all > non-x86 arches (or forces them to add a set of totally meaningless > PCI functions).
I agree, I quite dislike it too. Even If the breakage on x86 makes us want to totally disable it there, it can be done within the existing PCI ops I believe.
I think Arjan's problem is to try to do it per-device since the "standard" PCI ops don't get a pci_dev structure (for obvious reasons).
But from what I read in this thread, this per-device enabling/disabling doesn't seem very useful at all.
Cheers, Ben.
| |