| Date | Fri, 11 Jan 2008 15:24:34 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [patch 05/19] split LRU lists into anon & file sets |
| |
Hi Rik
> +static inline int is_file_lru(enum lru_list l) > +{ > + BUILD_BUG_ON(LRU_INACTIVE_FILE != 2 || LRU_ACTIVE_FILE != 3); > + return (l/2 == 1); > +}
below patch is a bit cleanup proposal. i think LRU_FILE is more clarify than "/2".
What do you think it?
Index: linux-2.6.24-rc6-mm1-rvr/include/linux/mmzone.h =================================================================== --- linux-2.6.24-rc6-mm1-rvr.orig/include/linux/mmzone.h 2008-01-11 11:10:30.000000000 +0900 +++ linux-2.6.24-rc6-mm1-rvr/include/linux/mmzone.h 2008-01-11 14:40:31.000000000 +0900 @@ -147,7 +147,7 @@ static inline int is_file_lru(enum lru_list l) { BUILD_BUG_ON(LRU_INACTIVE_FILE != 2 || LRU_ACTIVE_FILE != 3); - return (l/2 == 1); + return !!(l & LRU_FILE); }
struct per_cpu_pages {
|