lkml.org 
[lkml]   [2008]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core
    On Dec 29, 2007 7:42 PM, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
    > Matthew Wilcox wrote:
    > > Patches should be self-contained for ease of bisecting. I can't tell
    > > whether this patch is correct or not because you haven't included all
    > > the other places that need to change at the same time as this.
    >
    > I think a broken-up patch series isn't totally wrong to do for a first
    > look at these RFC patches. Of course the series needs to become a
    > single patch before it is committed to a tree whose history needs to
    > support bijection, e.g. -mm.
    >
    > However, Dave's postings lack a References: header which refer to his
    > 00/12 posting.

    Thanks. I agree with you, for bitsection it should be a single one.

    >
    > (Also, a bonus in the 00/12 posting would be a listing of all patch
    > titles in the series and the total diffstat of the series, but nearly
    > nobody does this.)

    Your sugestion is better.

    And, andrew recommends not to use 00/xx introduction email in series
    in his "The perfect patch":
    http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

    > --
    > Stefan Richter
    > -=====-=-=== ==-- ===-=
    > http://arcgraph.de/sr/
    >


    \
     
     \ /
      Last update: 2008-01-02 03:33    [W:4.427 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site