Messages in this thread | | | Date | Thu, 6 Sep 2007 01:56:03 +0000 | From | Pavel Machek <> | Subject | Re: [PATCH -mm] Hibernation: Check if ACPI is enabled during restore in the right place |
| |
On Sun 2007-09-02 00:21:37, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rjw@sisk.pl> > > The following scenario leads to total confusion of the platform firmware on > some boxes (eg. HPC nx6325): > * Hibernate with ACPI enabled > * Pass "acpi=off" to the boot kernel > > To prevent this from happening it's necessary to check if ACPI is enabled (and > enable it if that's not the case) _right_ _after_ control has been transfered > from the boot kernel to the image kernel, before device_power_up() is called > (ie. with interrupts disabled). Enabling ACPI after calling device_power_up() > turns out to be insufficient. > > For this reason, introduce new hibernation callback ->leave() that will be > executed before device_power_up() by the restored image kernel. To make it > work, it also is necessary to move swsusp_suspend() from swsusp.c to disk.c > (it's name is changed to "create_image", which is more up to the point). > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK.
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |