Messages in this thread | | | Date | Fri, 28 Sep 2007 11:38:10 -0700 | From | Paul Jackson <> | Subject | Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask |
| |
Mel replied to Lee: > > > + return nodes_intersect(nodemask, current->mems_allowed); > > ^^^^^^^^^^^^^^^ -- should be nodes_intersects, I think. > > Crap, you're right, I missed the warning about implicit declarations. I > apologise. This is the corrected version
I found myself making that same error, saying 'nodes_intersect' instead of 'nodes_intersects' the other day. And I might be the one who invented that name ;).
This would probably be too noisey and too little gain to do on the Linux kernel, but if this was just a little private project of my own, I'd be running a script over the whole thing, modifying all 30 or so instances of bitmap_intersects, cpus_intersects and nodes_intersects so as to remove the final 's' character.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |