Messages in this thread | | | Subject | Re: missing mnt_drop_write() on open error | From | Dave Hansen <> | Date | Tue, 25 Sep 2007 16:24:35 -0700 |
| |
On Wed, 2007-09-26 at 01:14 +0200, Miklos Szeredi wrote: > I get this at umount, if there was a failed open(): > > WARNING: at fs/namespace.c:586 __mntput() > > I think the problem is that may_open() calls mnt_want_write(), but if > open doesn't succeed, mnt_drop_write() will not be called.
I see what you're talking about, and it does look like a bug to me. I'm working on establishing where the 'struct file' gets created in relation to all of this, and where best we should back out the write count.
I should have a patch in a few.
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |