Messages in this thread Patch in this message | | | Date | Tue, 25 Sep 2007 12:45:34 -0700 | From | Andrew Morton <> | Subject | Re: [patch 5/7] Use extended crashkernel command line on ppc64 |
| |
On Tue, 25 Sep 2007 20:23:02 +0200 Bernhard Walle <bwalle@suse.de> wrote:
> This patch adapts the ppc64 code to use the generic parse_crashkernel() > function introduced in the generic patch of that series. > >
I really don't like to see patches get a wholesale replacement, especially when they've been looked at by a few people and have had some testing, etc. It's not possible to see what changed and people need to re-review stuff they've already reviewed, etc.
So I almost always undo this mess, turn the patches back into incremental ones, see what pops out.
This patch is actually:
diff -puN arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update arch/powerpc/kernel/machine_kexec.c --- a/arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update +++ a/arch/powerpc/kernel/machine_kexec.c @@ -63,7 +63,7 @@ NORET_TYPE void machine_kexec(struct kim void __init reserve_crashkernel(void) { - unsigned long long crash_size = 0, crash_base; + unsigned long long crash_size, crash_base; int ret; /* this is necessary because of lmb_phys_mem_size() */ _
which I suspect will now create a compiler warning.
unsigned long long crash_size, crash_base; int ret;
/* this is necessary because of lmb_phys_mem_size() */ lmb_analyze(); /* use common parsing */ ret = parse_crashkernel(boot_command_line, lmb_phys_mem_size(), &crash_size, &crash_base); if (ret == 0 && crash_size > 0) { if (crash_base == 0) crash_base = KDUMP_KERNELBASE; crashk_res.start = crash_base; } else { /* handle the device tree */ crash_size = crashk_res.end - crashk_res.start + 1; } if (crash_size == 0) return; If so, the use of uninitialized_var() would be better than the unneeded initialization-to-zero.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |