lkml.org 
[lkml]   [2007]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]
Date
On Tuesday 25 September 2007, Joachim Fenkes wrote:
> Extract generic of_device allocation code from of_platform_device_create()
> and move it into of_device.[ch], called of_device_alloc(). Also, there's now
> of_device_free() which puts the device node.
>
> Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
> ---
>  include/asm-powerpc/of_device.h   |    4 ++
>  include/linux/of_device.h         |    5 ++
>  arch/powerpc/kernel/of_device.c   |   80 +++++++++++++++++++++++++++++++++++++
>  arch/powerpc/kernel/of_platform.c |   70 +-------------------------------
>  4 files changed, 91 insertions(+), 68 deletions(-)
>

Sorry I didn't review the patches earlier when you sent them in private.
The patch looks good to me, especially since you did exactly what I
suggested ;-)

Maybe the description should have another sentence in it about what
the change is good for. You have that in the 0/5 mail, but that does
not go into the changelog, so the information gets lost in the process.

Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-25 16:41    [W:0.057 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site