Messages in this thread | | | Date | Mon, 24 Sep 2007 19:06:29 +0200 | From | Jochen Friedrich <> | Subject | Re: [PATCH4/4] [POWERPC] Fix cpm_uart driver |
| |
Scott Wood schrieb: > Jochen Friedrich wrote: >> >> In cpm_uart_core, functions cpm_uart_init_bd and cpm_uart_init_scc >> an offset into DP RAM is calculated by substracting a physical >> memory constant from an virtual address. This patch fixes the >> problem by converting the virtual address into a physical >> first. > > Huh? DPRAM_BASE is a virtual address. With this patch, you'd be > subtracting a virtual address from a physical address.
Thanks for pointing me to it. So the bug is in cpm_uart_cpm1.h assigning a physical memory to DPRAM_BASE (at least on ARC=ppc). cpm_uart_cpm2.h seems to be correct though. I'll submit a new patch for this.
Thanks, Jochen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |