Messages in this thread Patch in this message | | | From | trem <> | Subject | Re: 2.6.23-rc6-mm1 -- ipg.c don't compile on i386 with CONFIG_HIGHMEM64G | Date | Sun, 23 Sep 2007 16:19:05 +0200 |
| |
Hi
I've tried to compile 2.6.23-rc6-mm1, but it fails on ipg.c with the error : Setup is 10964 bytes (padded to 11264 bytes). System is 1640 kB Kernel: arch/i386/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 2030 modules WARNING: Can't handle masks in drivers/mtd/nand/cafe_nand:FFFF0 ERROR: "__udivdi3" [drivers/net/ipg.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 error: Bad exit status from /home/trem/rpm/tmp/rpm-tmp.23895 (%build)
I've instigated a bit, and I've found this code in ipg.c :
static void ipg_nic_txfree(struct net_device *dev) { struct ipg_nic_private *sp = netdev_priv(dev); void __iomem *ioaddr = sp->ioaddr; const unsigned int curr = ipg_r32(TFD_LIST_PTR_0) - (sp->txd_map / sizeof(struct ipg_tx)) - 1; unsigned int released, pending;
sp->txd_map is an u64 because : dma_addr_t txd_map;
And in asm-i386/types.h, I see : #ifdef CONFIG_HIGHMEM64G typedef u64 dma_addr_t; #else typedef u32 dma_addr_t; #endif I my config, I use CONFIG_HIGHMEM64G
sizeof(struct ipg_tx) is an u32 So the div failed on i386 because of u64 / u32.
I propose the following patch :
--- linux-2.6.22.old/drivers/net/ipg.c 2007-09-21 20:28:57.000000000 -0400 +++ linux-2.6.22.new/drivers/net/ipg.c 2007-09-21 20:22:15.000000000 -0400 @@ -837,7 +837,7 @@ static void ipg_nic_txfree(struct net_de struct ipg_nic_private *sp = netdev_priv(dev); void __iomem *ioaddr = sp->ioaddr; const unsigned int curr = ipg_r32(TFD_LIST_PTR_0) - - (sp->txd_map / sizeof(struct ipg_tx)) - 1; + do_div(sp->txd_map , sizeof(struct ipg_tx)) - 1; unsigned int released, pending;
IPG_DEBUG_MSG("_nic_txfree\n");
With this patch, it compiles on i386 and x86_64, but I haven't tested if this network card works (I don't have it).
regards, trem
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |