Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 10/22] CacheFiles: Add a hook to write a single page of data to an inode | Date | Sat, 22 Sep 2007 00:11:35 +0100 |
| |
Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> So why do you need a new address space operation? AFAICS the generic > implementation will work for pretty much everyone who supports the > existing prepare_write()/commit_write().
Because Christoph decreed that I wasn't allowed to call prepare_write() and commit_write() directly. It's possible that the method should be in the inode_operations rather than on the address space.
> Furthermore, you don't appear to supply any alternative "optimised" > implementations...
Optimised in what fashion?
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |