Messages in this thread | | | Date | Fri, 21 Sep 2007 03:56:47 +0200 | From | "Arvin Moezzi" <> | Subject | Re: [PATCH -mm] Don't truncate /proc/PID/environ at 4096 characters |
| |
2007/9/19, James Pearson <james-p@moving-picture.com>: > + while (count > 0) { > + int this_len, retval; > + > + this_len = mm->env_end - (mm->env_start + src); > + > + if (this_len <= 0) > + break; > + > + if (this_len > max_len) > + this_len = max_len; > + > + retval = access_process_vm(task, (mm->env_start + src), > + page, this_len, 0); > + > + if (retval <= 0) { > + ret = retval; > + break; > + } > + > + if (copy_to_user(buf, page, retval)) { ^^^^ shouldn't you only copy min(count,retval) bytes? otherwise you could write beyond the users buffer "buf", right?
Arvin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |