| Date | Wed, 19 Sep 2007 18:26:11 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 01/24] filesystem helpers for custom 'struct file's |
| |
On Mon, Sep 17, 2007 at 11:27:18AM -0700, Dave Hansen wrote: > > Christoph H. says this stands on its own and can go in before the > rest of the r/o bind mount set. > > --- > > Some filesystems forego the vfs and may_open() and create their > own 'struct file's. > > This patch creates a couple of helper functions which can be > used by these filesystems, and will provide a unified place > which the r/o bind mount code may patch. > > Also, rename an existing, static-scope init_file() to a less > generic name.
Looks good. But please provide a patch ontop of your patchkit to add kernel-doc comments for the two new exported functions.
Are there any direct caller of get_empty_filp left after this patch? We really should get rid of that export to stop people from shooting themselves in the foot.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|