Messages in this thread | | | Date | Tue, 18 Sep 2007 05:07:15 -0400 | From | Alan Cox <> | Subject | Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices |
| |
On Mon, Sep 17, 2007 at 07:00:03AM +0200, Tejun Heo wrote: > I wonder whether we should be using similar check in generic path too. > We have quite a few cases where MWDMA ATAPI devices choking on commands > with small transfer sizes. I don't think we'll experience significant > performance regression with this applied and even if there is some, it's > far better to have slightly slower working device. > > What do you guys think?
I think to start with someone should fix the ATAPI state machine. Stick a BUG() in the driver if dma start is called when the atapi command data size is zero
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |