Messages in this thread | | | Date | Wed, 19 Sep 2007 07:23:57 +0530 | From | Balbir Singh <> | Subject | Re: 2.6.23-rc6-mm1 panic (memory controller issue ?) |
| |
Badari Pulavarty wrote: > On Tue, 2007-09-18 at 15:21 -0700, Badari Pulavarty wrote: >> Hi Balbir, >> >> I get following panic from SLUB, while doing simple fsx tests. >> I haven't used any container/memory controller stuff except >> that I configured them in :( >> >> Looks like slub doesn't like one of the flags passed in ? >> >> Known issue ? Ideas ? >> > > I think, I found the issue. I am still running tests to > verify. Does this sound correct ? > > Thanks, > Badari > > Need to strip __GFP_HIGHMEM flag while passing to mem_container_cache_charge(). > > Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com> > mm/filemap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux-2.6.23-rc6/mm/filemap.c > =================================================================== > --- linux-2.6.23-rc6.orig/mm/filemap.c 2007-09-18 12:43:54.000000000 -0700 > +++ linux-2.6.23-rc6/mm/filemap.c 2007-09-18 19:14:44.000000000 -0700 > @@ -441,7 +441,8 @@ int filemap_write_and_wait_range(struct > int add_to_page_cache(struct page *page, struct address_space *mapping, > pgoff_t offset, gfp_t gfp_mask) > { > - int error = mem_container_cache_charge(page, current->mm, gfp_mask); > + int error = mem_container_cache_charge(page, current->mm, > + gfp_mask & ~__GFP_HIGHMEM); > if (error) > goto out; > > >
Hi, Badari,
The fix looks correct, radix_tree_preload() does the same thing in add_to_page_cache(). Thanks for identifying the fix
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |