Messages in this thread | | | Date | Tue, 18 Sep 2007 18:44:36 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only |
| |
Benjamin Herrenschmidt wrote: > To be more precise, a platform has every right to return some kind of > "token" from ioport_map/pci_iomap that encodes the type of address, and > that is -different- from what a normal ioremap does. In which case, you > will -not- be able to use readb/writeb & cie on such a token. > > The fact that current implementations seem to return something for MMIO > that is equivalent to what ioremap returns is an accident and cannot be > relied upon.
Fair enough. It's easy enough to change ath5k to using ioremap (or pci_ioremap).
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |