Messages in this thread | | | Date | Tue, 18 Sep 2007 16:12:56 -0400 | From | "Luis R. Rodriguez" <> | Subject | Re: [PATCH] Clarify pci_iomap() usage for MMIO-only devices |
| |
On 9/18/07, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > > On Tue, 18 Sep 2007, Luis R. Rodriguez wrote: > > > > ACK -- driver developers use this just to save themselves a few lines > > from calling pci_resource_start() and friends. How about having an > > inline which does what pci_iomap() does except it doesn't call > > ioport_map() ? I am just not sure where this would go.. > > I'm not understanding what the problem is? > > Why don't these people just use "ioread*()/iowrite*()"? > > In other words, the whole point of *not* using "read*/write*()" is that > you get a whole slew of much nicer interfaces. > > So can people explain this fundamental issue? Why do people insist on > using the old interfaces (and matching them with the new setup)?
An extra branch is created on MMIO-only devices on read/writes on the IO_COND macro using this interface -- or is this optimized out?
Luis - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |