lkml.org 
[lkml]   [2007]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] gpio_keys: add gpio_to_irq return code check
Hi Anti,

On 9/18/07, Anti Sullin <anti.sullin@artecdesign.ee> wrote:
> As David Brownell pointed out when reviewing my suspend patch to
> gpio_keys, the original gpio_keys driver does not check gpio_to_irq
> return code.
>
...
> - set_irq_type(irq, IRQ_TYPE_EDGE_BOTH);
> - error = request_irq(irq, gpio_keys_isr, IRQF_SAMPLE_RANDOM,
> - button->desc ? button->desc : "gpio_keys",
> - pdev);
> + if (irq < 0)

What would be the value of error variable (that we use as a return value) here?

> + goto fail;
> +

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-18 18:01    [W:0.231 / U:1.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site