Messages in this thread | | | Date | Sat, 15 Sep 2007 11:01:31 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: [PATCH] pci: fix unterminated pci_device_id lists |
| |
On Sep 13 2007 02:42, Jeff Garzik wrote: > Alexey Dobriyan wrote: >> -static struct pci_device_id rtl8139_pci_tbl[] = { >> +PCI_MODULE_DEVICE_TABLE_BEGIN(rtl8139_pci_tbl) >> {0x10ec, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, >> {0x10ec, 0x8138, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, >> {0x1113, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, >> @@ -273,10 +273,7 @@ static struct pci_device_id rtl8139_pci_tbl[] = { >> {PCI_ANY_ID, 0x8139, 0x10ec, 0x8139, 0, 0, RTL8139 }, >> {PCI_ANY_ID, 0x8139, 0x1186, 0x1300, 0, 0, RTL8139 }, >> {PCI_ANY_ID, 0x8139, 0x13d1, 0xab06, 0, 0, RTL8139 }, >> - >> - {0,} >> -}; >> -MODULE_DEVICE_TABLE (pci, rtl8139_pci_tbl); >> +PCI_MODULE_DEVICE_TABLE_END
That looks sooo... wxwidgets-like :)
> I think the previous version looks better.
Nod.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |