lkml.org 
[lkml]   [2007]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] Consolidate host virtualization support under Virtualization menu
    On Fri, 14 Sep 2007 15:18:44 +1000 Rusty Russell wrote:

    > We turn "Virtualization" into a menu, not a config option, since it's
    > actually only used as a menu. Then we move lguest under that menu.

    so you want to revert the 2007-july-16 merge that changes
    menu -> menuconfig and makes most of the menus consistent in
    presentation. I'd rather not, but I don't own it.

    And Yes, lguest does need to be moved into a better location.


    > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    >
    > diff -r c2893801de2a drivers/Kconfig
    > --- a/drivers/Kconfig Fri Sep 14 13:24:46 2007 +1000
    > +++ b/drivers/Kconfig Fri Sep 14 13:24:49 2007 +1000
    > @@ -87,6 +87,4 @@ source "drivers/kvm/Kconfig"
    > source "drivers/kvm/Kconfig"
    >
    > source "drivers/uio/Kconfig"
    > -
    > -source "drivers/lguest/Kconfig"
    > endmenu
    > diff -r c2893801de2a drivers/kvm/Kconfig
    > --- a/drivers/kvm/Kconfig Fri Sep 14 13:24:46 2007 +1000
    > +++ b/drivers/kvm/Kconfig Fri Sep 14 13:32:22 2007 +1000
    > @@ -1,21 +1,12 @@
    > #
    > # KVM configuration
    > #
    > -menuconfig VIRTUALIZATION
    > - bool "Virtualization"
    > +menu "Virtualization"
    > depends on X86
    > - default y
    > - ---help---
    > - Say Y here to get to see options for virtualization guest drivers.
    > - This option alone does not add any kernel code.
    > -
    > - If you say N, all options in this submenu will be skipped and disabled.
    > -
    > -if VIRTUALIZATION
    >
    > config KVM
    > tristate "Kernel-based Virtual Machine (KVM) support"
    > - depends on X86 && EXPERIMENTAL
    > + depends on EXPERIMENTAL
    > select ANON_INODES
    > ---help---
    > Support hosting fully virtualized guest machines using hardware
    > @@ -45,4 +36,8 @@ config KVM_AMD
    > Provides support for KVM on AMD processors equipped with the AMD-V
    > (SVM) extensions.
    >
    > -endif # VIRTUALIZATION
    > +# OK, it's a little counter-intuitive to do this, but it puts it neatly under
    > +# the virtualization menu.
    > +source drivers/lguest/Kconfig
    > +
    > +endmenu


    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-14 21:39    [W:2.647 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site