Messages in this thread | | | Date | Wed, 12 Sep 2007 21:15:07 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] usb: fix unterminated usn_device_id lists |
| |
Kees Cook wrote: > This patch against 2.6.23-rc6 fixes a unterminated list of USB device ids. > > Signed-off-by: Kees Cook <kees@ubuntu.com> > --- > linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c | 1 + > 1 file changed, 1 insertion(+) > --- > diff -urp -x '*.o' linux-2.6.23-rc6~/drivers/media/video/usbvision/usbvision-cards.c linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c > --- linux-2.6.23-rc6~/drivers/media/video/usbvision/usbvision-cards.c 2007-09-11 23:17:19.000000000 -0700 > +++ linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c 2007-09-12 17:26:46.000000000 -0700 > @@ -1081,6 +1081,7 @@ struct usb_device_id usbvision_table [] > { USB_DEVICE(0x2304, 0x0301), .driver_info=PINNA_LINX_VD_IN_CAB_PAL }, > { USB_DEVICE(0x2304, 0x0419), .driver_info=PINNA_PCTV_BUNGEE_PAL_FM }, > { USB_DEVICE(0x2400, 0x4200), .driver_info=HPG_WINTV }, > + { 0, },
FWIW I (and several drivers) tend to prefer the more clean version,
{ },
or even
{ }, /* terminate list */
Regards,
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |