lkml.org 
[lkml]   [2007]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Intel FB pixel clock calculation fix
On Mon, 10 Sep 2007 21:24:42 +0200 Krzysztof Halasa <khc@pm.waw.pl> wrote:

> Intel framebuffer mis-calculated pixel clocks.
>
> Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
>
> --- a/drivers/video/intelfb/intelfbhw.c
> +++ b/drivers/video/intelfb/intelfbhw.c
> @@ -924,10 +920,10 @@ calc_pll_params(int index, int clock, u32 *retm1, u32 *retm2, u32 *retn, u32 *re
> if (m > pll->max_m)
> m = pll->max_m - 1;
> for (testm = m - 1; testm <= m; testm++) {
> - f_out = calc_vclock3(index, m, n, p);
> + f_out = calc_vclock3(index, testm, n, p);
> if (splitm(index, testm, &m1, &m2)) {
> - WRN_MSG("cannot split m = %d\n", m);
> - n++;
> + WRN_MSG("cannot split m = %d\n",
> + testm);
> continue;
> }
> if (clock > f_out)

and... what are the consequences of this miscalculation? I need to know
such things so that I can decide whether a change is needed in 2.6.23. And
2.6.22.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-09-11 07:55    [W:0.054 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site