Messages in this thread | | | Date | Mon, 10 Sep 2007 15:03:52 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH 2/2] forbid asm/bitops.h direct inclusion |
| |
On Mon, Sep 10, 2007 at 01:28:38PM +0100, Ralf Baechle wrote: > On Sat, Sep 08, 2007 at 09:00:48PM +0100, Jiri Slaby wrote: > > > forbid asm/bitops.h direct inclusion > > > > Because of compile errors that may occur after bit changes if asm/bitops.h is > > included directly without e.g. linux/kernel.h which includes linux/bitops.h, forbid > > direct inclusion of asm/bitops.h. Thanks to Adrian Bunk. > > This is the kind of thing that checkpatch.pl is already checking for and > I like that idea much more than adding thousands of checks over many of > the header files under asm.
Checks in the header are only for header files where including only the asm header doesn't work which doesn't seem to be the common case.
> Ralf
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |