Messages in this thread | | | Date | Wed, 08 Aug 2007 10:32:50 +0200 | From | Martin Wilck <> | Subject | Re: PATCH/RFC: [kdump] fix APIC shutdown sequence |
| |
Hello Andrew,
thanks a lot for looking at this patch.
> Please feed the diff through scripts/checkpatch.pl. It finds a lot of issues.
I should have read the latest version of SubmittingPatches :-( I didn't expect you to pick up this patch so quickly, if I did I'd have cleaned it more thoroughly. I apologize.
I expect this patch to go through a few more iterations in discussions with Vivek and other people on this list.
> This is tricky code which you're adding. Empirically-based stuff derived > from observation and experimentation. It is quite impossible for readers > of this code to work out what the code is doing and why it is doing it > purely by reading the C statements.
OK. I thought this might make the patch itself too long, that's why I put it into the header.
Thanks, Martin
-- Martin Wilck PRIMERGY System Software Engineer FSC IP ESP DE6
Fujitsu Siemens Computers GmbH Heinz-Nixdorf-Ring 1 33106 Paderborn Germany
Tel: ++49 5251 8 15113 Fax: ++49 5251 8 20409 Email: mailto:martin.wilck@fujitsu-siemens.com Internet: http://www.fujitsu-siemens.com Company Details: http://www.fujitsu-siemens.com/imprint.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |