lkml.org 
[lkml]   [2007]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition
On Thu, Aug 30, 2007 at 01:50:59PM +0200, Andre Haupt wrote:
> On Thu, Aug 30, 2007 at 05:17:47AM -0600, Matthew Wilcox wrote:
> > On Thu, Aug 30, 2007 at 12:40:38PM +0200, andre@finow14.de wrote:
> > > - diff_int = my_abs(rate_ext-rate);
> > > - diff_ext = my_abs(rate_int-rate);
> > > + diff_int = abs(rate_ext-rate);
> > > + diff_ext = abs(rate_int-rate);
> >
> > Nothing to do with the patch, but is this really correct? Surely it
> > should be diff_ext = abs(rate_ext-rate) ?
>
> hmmh, not sure about this ...

No idea. The support for external clocking came from someone else
(I was never able to work it out myself).

I can only assume that the code as it stands does work. So let's
remain bug-compatible until there's a proven problem.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-30 14:35    [W:0.024 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site