Messages in this thread | | | Date | Thu, 30 Aug 2007 21:11:05 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: [PATCH] Use helpers to obtain task pid in printks (arch code) |
| |
On Aug 27 2007 11:01, Joe Perches wrote: >On Mon, 2007-08-27 at 11:30 +0400, Pavel Emelyanov wrote: >> From: Alexey Dobriyan <adobriyan@openvz.org> >> >> One of the easiest things to isolate is the pid printed in kernel >> log. There was a patch, that made this for arch-independent code, >> this one makes so for arch/xxx files. > >Perhaps it would be worthwhile to standardize the printk >task information content? Maybe a format knob? > >Maybe TASK_FMT/TASK_ARG(task) > >#define TASK_FMT "%s" >#define TASK_ARG(tsk) ({char __buf[MAX_TASK_INFO]; print_task(tsk, buf, sizeof(__buf)); __buf})
Except that __buf goes out of scope before printk() is called...
Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |