Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions | Date | Thu, 30 Aug 2007 20:22:23 +0200 |
| |
On Wednesday 29 August 2007, Joachim Fenkes wrote: > Previously, ibmebus derived a device's bus_id from its location code. The > location code is not guaranteed to be unique, so we might get bus_id > collisions if two devices share the same location code. The OFDT full_name, > however, is unique, so we use that instead. > > Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
Actually, I think it would be much better to convert the code to be more like of_platform_device, or to even replace all of ibmebus with that.
The whole logic of dynamically adding and removing device is rather bogus, and it prevents autoloading of device drivers. of_platform_make_bus_id is the function that is responsible for creating unique names over there.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |