Messages in this thread | | | Date | Thu, 30 Aug 2007 08:45:02 -0600 | From | "Jordan Crouse" <> | Subject | Re: ALSA: cs5535audio: fix ACC_BM[x]_CMD register handling |
| |
On 29/08/07 23:30 -0400, Andres Salomon wrote: > > ACcording to 6.3.2.7 of the cs5535/cs5536 data sheets, the ACC_BM[x]_CMD > registers are only 8 bits wide. This driver treats them as 32 bits wide, > and also has bits in the wrong place. Simple fix to the definitions. > > Signed-off-by: Andres Salomon <dilinger@debian.org> Acked-by: Jordan Crouse <jordan.crouse@amd.com> > --- > > sound/pci/cs5535audio/cs5535audio.h | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sound/pci/cs5535audio/cs5535audio.h b/sound/pci/cs5535audio/cs5535audio.h > index c7a2044..516219a 100644 > --- a/sound/pci/cs5535audio/cs5535audio.h > +++ b/sound/pci/cs5535audio/cs5535audio.h > @@ -62,11 +62,11 @@ > #define EOP (1<<0) > #define BM_EOP_ERR (1<<1) > /* ACC_BMX_CTL */ > -#define BM_CTL_EN 0x00000001 > -#define BM_CTL_PAUSE 0x00000011 > -#define BM_CTL_DIS 0x00000000 > -#define BM_CTL_BYTE_ORD_LE 0x00000000 > -#define BM_CTL_BYTE_ORD_BE 0x00000100 > +#define BM_CTL_EN 0x01 > +#define BM_CTL_PAUSE 0x03 > +#define BM_CTL_DIS 0x00 > +#define BM_CTL_BYTE_ORD_LE 0x00 > +#define BM_CTL_BYTE_ORD_BE 0x04 > /* cs5535 specific ac97 codec register defines */ > #define CMD_MASK 0xFF00FFFF > #define CMD_NEW 0x00010000 > >
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |