Messages in this thread | | | Date | Thu, 30 Aug 2007 02:46:41 +0200 | From | Björn Steinbrink <> | Subject | Re: [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3 |
| |
On 2007.08.29 10:49:12 -0700, Christoph Lameter wrote: > On Wed, 29 Aug 2007, Peter Lund wrote: > > > > > - if (tmp >= RADIX_TREE_INDEX_BITS) > > - index = ~0UL; > > - return index; > > + if (shift < 0) > > + return ~0UL; > > + if (shift >= 8 * sizeof(unsigned long)) > > 8* sizeof(unsigned long) is the constant BITS_PER_LONG.
Or in this context: RADIX_TREE_INDEX_BITS, which happens to be the old check, which just needed to be extended to cover negative shifts.
Björn - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |