lkml.org 
[lkml]   [2007]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [md-accel PATCH 16/19] dmaengine: driver for the iop32x, iop33x, and iop13xx raid engines
Hi Dan,
I think you have a bug in this function, the list_splice_init adds the
new slots in the head of the chain_node, but you get the
old_chain_tail (latest descriptor) from the tail of the chain!!

> +static dma_cookie_t
> +iop_adma_tx_submit(struct dma_async_tx_descriptor *tx)
> +{
> +
> + old_chain_tail = list_entry(iop_chan->chain.prev,
> + struct iop_adma_desc_slot, chain_node);
> + list_splice_init(&sw_desc->group_list, &old_chain_tail->chain_node);
> +
> + /* fix up the hardware chain */
> + iop_desc_set_next_desc(old_chain_tail, grp_start->phys);
> +
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-27 15:29    [W:0.689 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site