Messages in this thread | | | Subject | Re: [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer | From | (Frank Ch. Eigler) | Date | Sat, 25 Aug 2007 07:06:54 -0400 |
| |
Steven Rostedt <rostedt@goodmis.org> writes:
> [...] > + * [...] We don't need to grab > + * any locks, we just keep trying until get all the > + * calculations together in one state. > + * > + * In fact, we __cant__ grab any locks. This > + * function is called from the latency_tracer which can > + * be called anywhere. To grab any locks (including > + * seq_locks) we risk putting ourselves into a deadlock.
Perhaps you could add a comment about why the loop, which appears potentially infinite as written, avoids livelock. (It looks rather like a seqlock read loop.)
- FChE - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |