Messages in this thread | | | Date | Thu, 23 Aug 2007 15:27:10 +1000 | From | Tim Shimmin <> | Subject | Re: [BUG] fs/xfs/xfs_bmap_btree.c:2312: error: 'b' undeclared (first use in this function) (Was Re: 2.6.23-rc3-mm1) |
| |
Hi Michal,
Thanks for the patch. This would be a problem for 32bit machines without large blocksize support (i.e. in our xfs tests: !XFS_BIG_BLKNOS => (BITS_PER_LONG == 32 && !defined(CONFIG_LBD)) which we obviously didn't do a build test for.
I'll check it into our local tree and push to the master branch for Andrew.
--Tim
Michal Piotrowski wrote: > Michal Piotrowski pisze: >> Andrew Morton pisze: >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/ >>> >> /home/devel/linux-mm/fs/xfs/xfs_bmap_btree.c: In function 'xfs_bmbt_set_allf': >> /home/devel/linux-mm/fs/xfs/xfs_bmap_btree.c:2312: error: 'b' undeclared (first use in this function) >> /home/devel/linux-mm/fs/xfs/xfs_bmap_btree.c:2312: error: (Each undeclared identifier is reported only once >> /home/devel/linux-mm/fs/xfs/xfs_bmap_btree.c:2312: error: for each function it appears in.) >> /home/devel/linux-mm/fs/xfs/xfs_bmap_btree.c: In function 'xfs_bmbt_disk_set_allf': >> /home/devel/linux-mm/fs/xfs/xfs_bmap_btree.c:2372: error: 'b' undeclared (first use in this function) >> make[3]: *** [fs/xfs/xfs_bmap_btree.o] Error 1 >> make[2]: *** [fs/xfs] Error 2 >> make[1]: *** [fs] Error 2 >> make: *** [_all] Error 2 >> > > Build fix. > > Regards, > Michal > > -- > LOG > http://www.stardust.webpages.pl/log/ > > Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com> > > --- linux-mm-clean/fs/xfs/xfs_bmap_btree.c 2007-08-22 12:20:35.000000000 +0200 > +++ linux-mm/fs/xfs/xfs_bmap_btree.c 2007-08-22 12:15:52.000000000 +0200 > @@ -2309,7 +2309,7 @@ xfs_bmbt_set_allf( > ((xfs_bmbt_rec_base_t)blockcount & > (xfs_bmbt_rec_base_t)XFS_MASK64LO(21)); > #else /* !XFS_BIG_BLKNOS */ > - if (ISNULLSTARTBLOCK(b)) { > + if (ISNULLSTARTBLOCK(startblock)) { > r->l0 = ((xfs_bmbt_rec_base_t)extent_flag << 63) | > ((xfs_bmbt_rec_base_t)startoff << 9) | > (xfs_bmbt_rec_base_t)XFS_MASK64LO(9); > @@ -2369,7 +2369,7 @@ xfs_bmbt_disk_set_allf( > ((xfs_bmbt_rec_base_t)blockcount & > (xfs_bmbt_rec_base_t)XFS_MASK64LO(21))); > #else /* !XFS_BIG_BLKNOS */ > - if (ISNULLSTARTBLOCK(b)) { > + if (ISNULLSTARTBLOCK(startblock)) { > r->l0 = cpu_to_be64( > ((xfs_bmbt_rec_base_t)extent_flag << 63) | > ((xfs_bmbt_rec_base_t)startoff << 9) | > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |