Messages in this thread | | | From | Blaisorblade <> | Subject | Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section | Date | Thu, 23 Aug 2007 16:50:37 +0200 |
| |
On mercoledì 22 agosto 2007, Jeff Dike wrote: > On Tue, Aug 21, 2007 at 07:05:53PM +0200, Blaisorblade wrote: > > It's not the first time we hit effects of such bugs, is it? > > I don't remember seeing this before. > > > The .note.ABI-tag fix, time ago, may be about the same problem. > > Are you referring to > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdi >ff;h=c35e584c087381aaa5f1ed40a28b978535c18fb2;hp=a5bd1786fb30abe663b904f6d79 >bba413e9ba883?
Yes.
>If so, I never understood that - it just came in saying "this > fixes static building", so I sent it along.
In this case, I'm referring to the patch which had a typo, which is yours:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7632fc8f809a97f9d82ce125e8e3e579390ce2e5 Description follows: "During a static link, ld has started putting a .note section in the .uml.setup.init section. This has the result that the UML setups begin with 32 bytes of garbage and UML crashes immediately on boot.
This patch creates a specific .note section for ld to drop this stuff into."
My patch only made your change work for real - IIRC you had fixed that exact typo too, but you forgot to run quilt refresh before sending the patch (btw, quilt pop -a will force you to refresh all patches to succeed - I do it frequently).
> BTW, that commit was singled > out by git-bisect as "causing" this particular problem. > > > Can you > > double-check all UML linker scripts for more instances of this bug? > > I did, I have a patch, and it's been verified to fix the problem.
In this case, we _may_ want to remove the .note section altogether - even if it is likely to shake out more problems.
Good bye! -- "Doh!" (cit.), I've made another another mistake! Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade [unhandled content-type:application/pgp-signature] | |