lkml.org 
[lkml]   [2007]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][Fix] Hibernation: Do not try to mark invalid PFNs as nosave
Hi!

> [Please consider as 2.6.23 material.]
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> On some systems some PFNs reported by the early initialization code as 'nosave'
> may be invalid. If we try to set the corresponding bits in the hibernation
> bitmap, BUG_ON() in memory_bm_find_bit() will be triggered and the system
> won't be able to boot (cf. https://bugzilla.novell.com/show_bug.cgi?id=296242).
>
> Prevent this from happening by verifying if the 'nosave' PFNs are valid in
> mark_nosave_pages().
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

ACK.

> @@ -709,7 +709,8 @@ static void mark_nosave_pages(struct mem
> region->end_pfn << PAGE_SHIFT);
>
> for (pfn = region->start_pfn; pfn < region->end_pfn; pfn++)
> - memory_bm_set_bit(bm, pfn);
> + if (pfn_valid(pfn))
> + memory_bm_set_bit(bm, pfn);
> }
> }
>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-02 19:59    [W:0.020 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site