Messages in this thread Patch in this message | | | From | Andy Whitcroft <> | Subject | [PATCH 5/6] irda_nl_get_mode: always results in failure | Date | Thu, 16 Aug 2007 14:19:06 +0100 |
| |
It seems an extraneous trailing ';' has slipped in to the error handling for a name registration failure causing the error path to trigger unconditionally.
Signed-off-by: Andy Whitcroft <apw@shadowen.org> Cc: Samuel Ortiz <samuel@sortiz.org> Cc: irda-users@lists.sourceforge.net --- net/irda/irnetlink.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/irnetlink.c b/net/irda/irnetlink.c index 694ea4d..1e429c9 100644 --- a/net/irda/irnetlink.c +++ b/net/irda/irnetlink.c @@ -106,7 +106,7 @@ static int irda_nl_get_mode(struct sk_buff *skb, struct genl_info *info) } if(nla_put_string(msg, IRDA_NL_ATTR_IFNAME, - dev->name)); + dev->name)) goto err_out; if(nla_put_u32(msg, IRDA_NL_ATTR_MODE, irlap->mode)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |