Messages in this thread Patch in this message | | | Date | Wed, 15 Aug 2007 16:46:25 +0800 | From | Fengguang Wu <> | Subject | Re: [patch 2/2] Sort module list by pointer address to get coherent sleepable seq_file iterators |
| |
Al Viro,
Does this sounds like a good fix? ===
seq_file version fixes
- f_version is 'unsigned long', it's pointless to do more than that. - m->version should not be reset when we are bumping up the buf size.
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn> --- fs/seq_file.c | 1 - include/linux/seq_file.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.23-rc3.orig/include/linux/seq_file.h +++ linux-2.6.23-rc3/include/linux/seq_file.h @@ -18,7 +18,7 @@ struct seq_file { size_t from; size_t count; loff_t index; - loff_t version; + unsigned long version; struct mutex lock; const struct seq_operations *op; void *private; --- linux-2.6.23-rc3.orig/fs/seq_file.c +++ linux-2.6.23-rc3/fs/seq_file.c @@ -134,7 +134,6 @@ ssize_t seq_read(struct file *file, char if (!m->buf) goto Enomem; m->count = 0; - m->version = 0; } m->op->stop(m, p); m->count = 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |