Messages in this thread | | | Date | Sun, 12 Aug 2007 13:47:26 +0200 | From | Willy Tarreau <> | Subject | Re: [2.6.20.16 review 27/28] NTP: remove clock_was_set() call to prevent deadlock |
| |
On Sun, Aug 12, 2007 at 04:15:58AM -0700, Jason Uhlenkott wrote: > On Sat, Aug 11, 2007 at 21:48:19 +0200, Willy Tarreau wrote: > > The clock_was_set() call in seconds_overflow() which happens only when > > leap seconds are inserted / deleted is wrong in two aspects: > > > > 1. it results in a call to on_each_cpu() with interrupts disabled > > 2. it is potential deadlock source vs. call_lock in smp_call_function() > > clock_was_set() is a no-op in 2.6.20, so this one looks unnecessary > (but harmless). Thankfully the "hang every Linux box on the planet > simultaneously" regression (okay, that's *slight* hyperbole) was > limited to 2.6.21.
OK, patch removed.
Thanks for your help, Willy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |