Messages in this thread | | | Subject | Re: [patch 3/4] Enable link power management for ata drivers | From | Valdis.Kletnieks@vt ... | Date | Sat, 11 Aug 2007 00:58:49 -0400 |
| |
On Thu, 09 Aug 2007 14:24:16 PDT, Kristen Carlson Accardi said: > +++ 2.6-git/drivers/ata/libata-scsi.c > @@ -2904,6 +2976,52 @@ void ata_scsi_simulate(struct ata_device
> + if ((dev->horkage & ATA_HORKAGE_IPM) || > + !(dev->flags & ATA_DFLAG_IPM)) { > + ata_dev_printk(dev, KERN_ERR, > + "Unable to set Link PM policy\n"); > + ap->pm_policy = MAX_PERFORMANCE; > + }
KERN_INFO please, or KERN_WARNING at the highest, at least until such time as enough drivers support enough hardware that it really *does* qualify for "this should not fail" status.
(OK, so I'm just cranky because I'm tired of seeing a KERN_ERR thrown at every reboot, just because the ata_piix driver doesn't know how to set this stuff up for the DVD?RW drive in my laptop. But when this goes upstream, lots of *other* people are going to get hit by the exact same thing and think there's something actually *wrong* with their hardware.) [unhandled content-type:application/pgp-signature] | |