Messages in this thread | | | Date | Sat, 11 Aug 2007 11:45:21 +0200 (CEST) | From | Stefan Richter <> | Subject | Re: [PATCH] fix crash in sbp2_remove_device() when dma_set_mask() fails |
| |
On 6 Aug, Olaf Hering wrote: > --- a/drivers/ieee1394/sbp2.c > +++ b/drivers/ieee1394/sbp2.c > @@ -929,13 +929,14 @@ static void sbp2_remove_device(struct sb > if (!lu) > return; > > - hi = lu->hi; > - > if (lu->shost) { > scsi_remove_host(lu->shost); > scsi_host_put(lu->shost); > } > flush_scheduled_work(); > + hi = lu->hi; > + if (!hi) > + return;
We need to kfree lu here. Patch comes right away.
> sbp2util_remove_command_orb_pool(lu); > > list_del(&lu->lu_list); > @@ -977,8 +978,7 @@ static void sbp2_remove_device(struct sb > > lu->ud->device.driver_data = NULL; > > - if (hi) > - module_put(hi->host->driver->owner); > + module_put(hi->host->driver->owner); > > kfree(lu); > }
-- Stefan Richter -=====-=-=== =--- -=-== http://arcgraph.de/sr/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |