Messages in this thread | | | Date | Mon, 9 Jul 2007 17:29:29 -0700 | From | sukadev@us ... | Subject | Re: [PATCH 0/16] Pid namespaces |
| |
Pavel Emelianov [xemul@openvz.org] wrote: | This is "submition for inclusion" of hierarchical, not kconfig | configurable, zero overheaded ;) pid namespaces. | | The overall idea is the following: | | The namespace are organized as a tree - once a task is cloned | with CLONE_NEWPIDS (yes, I've also switched to it :) the new
Can you really clone() a pid namespace all by itself ? copy_namespaces() has the following:
if (!(flags & (CLONE_NEWNS | CLONE_NEWUTS | CLONE_NEWIPC | CLONE_NEWUSER))) return 0;
doesn't it mean you cannot create a pid namespace using clone() unless one of the above flags are also specified ?
unshare_nsproxy_namespaces() has the following correct check:
if (!(unshare_flags & (CLONE_NEWNS | CLONE_NEWUTS | CLONE_NEWIPC | CLONE_NEWUSER | CLONE_NEWPIDS))) return 0;
BTW, why not use CLONE_NEWPID and drop the 'S' ? We don't have 'S' with other namespaces.
Suka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |