Messages in this thread | | | Date | Sat, 7 Jul 2007 01:18:03 +0400 | From | Alexey Dobriyan <> | Subject | Re: [PATCH] Some love to default profiler |
| |
On Thu, Jul 05, 2007 at 01:50:27AM +0200, Jesper Juhl wrote: > One tiny comment below.
> >+#define prof_on 0 > >+static inline void profile_init(void) > >+{ > >+} > > Just to be pedantic; don't we want a blank line between functions > here, even if they are empty?
Dunno, it's boilerplate code, nobody reads it.
> >+static inline void profile_tick(int type) > >+{ > >+} > >+static inline void profile_hits(int type, void *ip, unsigned int nr_hits) > >+{ > >+} > >+static inline void profile_hit(int type, void *ip) > >+{ > >+} > >+static inline void profile_munmap(unsigned long addr) > >+{ > >+} > >+static inline void profile_task_exit(struct task_struct *tsk) > >+{ > >+} > >+static inline int profile_handoff_task(struct task_struct *tsk) > >+{ > >+ return 0; > >+}
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |