Messages in this thread | | | Date | Fri, 6 Jul 2007 11:09:00 +0100 | From | "Adrian McMenamin" <> | Subject | Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix behaviour in poor resource conditions |
| |
On 06/07/07, Takashi Iwai <tiwai@suse.de> wrote: > I guess you shoud call del_timer() there at least. Otherwise the > timer handler (aica_period_elapsed()) might be called even if the > stream is not really running. >
Fair enough. I'll fix that and repost later.
> The below is some coding style fixes, BTW. I'm not sure whether > queue_work() is intended in the block if "if (dma_check == 0)" or > not. >
It's just an aberrant indent - I think there was an independent block there in earlier code, it got removed but the tab stayed :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |