Messages in this thread | | | Date | Fri, 6 Jul 2007 12:59:28 +0530 | From | "Satyam Sharma" <> | Subject | Re: [PATCH] Libertas: Fix regression in cmd.c introduced in commit 18c96c3497aa871608d57ca5e08de3558159a6c9 |
| |
Hi Guillaume,
[ Added relevant folks to Cc: ]
On 7/6/07, Guillaume LECERF <glecerf@gmail.com> wrote: > [...] > > --- a/drivers/net/wireless/libertas/cmd.c > +++ b/drivers/net/wireless/libertas/cmd.c > @@ -241,7 +241,7 @@ > if (*enable) > penableRSN->enable = cpu_to_le16(cmd_enable_rsn); > else > - penableRSN->enable = cpu_to_le16(cmd_enable_rsn); > + penableRSN->enable = cpu_to_le16(cmd_disable_rsn); > } > > lbs_deb_leave(LBS_DEB_CMD); >
Thanks for the patch (looks reasonable to me), but:
1. No point sending a patch without a "Signed-off-by:" line. 2. Changelog (a few lines of explanation before signed-off-by) must specify what was wrong, and why the patch is correct. 3. Always Cc: relevant maintainers or at least _somebody_ who _will_ pick it up. 4. Gmail has done horrible things to the patch as usual, use some other mailer or script.
And in general, please read: Documentation/SubmittingPatches and http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |