Messages in this thread | | | Date | Mon, 23 Jul 2007 13:54:16 -0700 | From | Christoph Lameter <> | Subject | Re: [PATCH] Check for compound pages in set_page_dirty() |
| |
On Thu, 19 Jul 2007 18:35:17 +0100 (BST) Hugh Dickins <hugh@veritas.com> wrote:
> I didn't see any attention to set_page_dirty in Christoph's > Large Blocksize (variable page_cachesize) patches, but I expect > he'd also be wanting set_page_dirty to act on compound_head.
There is no need for special casing if set_page_dirty() is only ever called for page heads. Make sure that direct I/O does not call set_page_dirty for tail pages.
A VM_BUG_ON(PageTail(page)) could be used to make sure that this does not happen in the future? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |