Messages in this thread | | | Date | Mon, 23 Jul 2007 14:32:20 +0300 | From | Avi Kivity <> | Subject | Re: [RFC 7/8]KVM: swap out guest pages |
| |
Shaohua Li wrote: > Make KVM guest pages be allocated dynamically and able to be swaped out. > > One issue: all inodes returned from anon_inode_getfd are shared, > if one module changes field of the inode, other moduels might break. > Should we introduce a new API to not share inode? > > Signed-off-by: Shaohua Li <shaohua.li@intel.com> > --- > drivers/kvm/kvm.h | 8 + > drivers/kvm/kvm_main.c | 220 +++++++++++++++++++++++++++++++++++++++++++++---- > 2 files changed, 211 insertions(+), 17 deletions(-) > > + > + /* > + * We just zap vcpu 0's page table. For a SMP guest, we should zap all > + * vcpus'. It's better shadow page table is per-vm. > + */ > + if (PagePrivate(page)) > + kvm_mmu_zap_pagetbl(&kvm->vcpus[0], page->index); > + >
You're not removing any shadows of the page, in case that page is a guest page table. But I don't see anything wrong with it -- the page won't change while it's in swap.
-- error compiling committee.c: too many arguments to function
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |