Messages in this thread | | | Date | Mon, 23 Jul 2007 13:46:43 +0300 | From | Avi Kivity <> | Subject | Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch |
| |
Shaohua Li wrote: > fix some bugs in kvm-sch patch. >
There is now a 'preempt-hooks' branch on kvm.git with the preempt-hooks work. I'll continually update and rebase it against master.
> 1. vmcs_readl/vmcs_writel are called with preempt enabled >
Why is that bad?
> 2. preempt_count check doesn't make sense with preempt disabled >
That is already fixed in the branch.
> 3. vmx_cpu_run doesn't handle error correctly and kvm_mmu_reload might > sleep with mutex changes, so I move it above. >
Yes.
> @@ -2001,6 +1997,10 @@ preempted: > kvm_guest_debug_pre(vcpu); > > again: > + r = kvm_mmu_reload(vcpu); > + if (unlikely(r)) > + goto out; > + > preempt_disable(); > > if (!vcpu->mmio_read_completed) > @@ -2009,10 +2009,6 @@ again: > vmx_save_host_state(vcpu); > kvm_load_guest_fpu(vcpu); > > - r = kvm_mmu_reload(vcpu); > - if (unlikely(r)) > - goto out; > - > /* > * Loading guest fpu may have cleared host cr0.ts > */ >
I'll add this (and the spinlock->mutex conversion) to the branch.
-- error compiling committee.c: too many arguments to function
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |