Messages in this thread | | | Date | Sun, 22 Jul 2007 21:06:12 +0100 | From | Stephen Hemminger <> | Subject | Re: New wake ups from sky2 |
| |
On Sat, 21 Jul 2007 11:00:38 +0200 Thomas Meyer <thomas@m3y3r.de> wrote:
> Stephen Hemminger schrieb: > > Thomas Meyer <thomas@m3y3r.de> wrote: > > > > > >> Today i did a git pull to be up to date again and i noticed in the > >> powertop tool that i'll get this new entry > >> > >> 14,2% ( 9,1) <kernel core> : sky2_probe (sky2_idle) > >> > >> with around 10 interrupts per second. > >> > >> i think (i.e. i don't know and just guessing!) this commit is > >> responsible for these wake ups: > >> > >> git show eb35cf60e462491249166182e3e755d3d5d91a28 > >> > >> Author: Stephen Hemminger <shemminger@osdl.org> > >> Date: Tue Jun 13 17:17:31 2006 +0900 > >> > >> [PATCH] sky2: stop/start hardware idle timer on suspend/resume > >> > >> The resume bug was caused not by an early interrupt but because the idle > >> timeout was not being stopped on suspend. Also disable hardware IRQ's > >> on suspend. Will need to revisit this with hotplug? > >> > >> Signed-off-by: Stephen Hemminger <shemminger@osdl.org> > >> Signed-off-by: Linus Torvalds <torvalds@osdl.org> > >> > >> Any ideas? > >> > >> > > > > Last version has idle timer enabled. > > It is a tradeoff between device hanging due to lost interrupt or wasting power. > > You can make the timeout longer by setting idle_timeout module parameter larger, > > (or zero which will disable it). > > > Ok. But do you need to start the timer when no cable is plugged in, like > in the case above?
Probably not, because risk of missed PHY interrupt is miniscule. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |