Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] x86_64: use apic core id bits for core nums | Date | Sat, 21 Jul 2007 14:28:46 +0200 |
| |
On Saturday 21 July 2007 13:21:34 Yinghai Lu wrote: > On 7/21/07, Andi Kleen <ak@suse.de> wrote: > > On Saturday 21 July 2007 09:56:15 Yinghai Lu wrote: > > > please check my version, we should use core id bits instead. > > > > > > it should replace > > > [PATCH for review] [37/48] x86_64: make k8topology multi-core aware > > > > Yes, you're right the patch is not good. It should probably use > > information from the regular CPU setup code, not touch cpuid > > directly > > need move some code into early_identify_cpu from identify_cpu in > arch/x86_64/kernel/setup.c > then could use that bits in bsp cpu info.
Yes something like this
> BTW: > it seems for BSP only early_identify_cpu is called, and identify_cpu > is only use in smp_callin for AP. Do i miss sth.
identify_cpu calls early_identify_cpu as first thing.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |