| Date | Thu, 19 Jul 2007 10:15:55 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node |
| |
On 7/19/07, Andi Kleen <ak@suse.de> wrote: > > From: David Rientjes <rientjes@google.com> > In acpi_scan_nodes(), we immediately return -1 if acpi_numa <= 0, meaning > we haven't detected any underlying ACPI topology or we have explicitly > disabled its use from the command-line with numa=noacpi. > > acpi_table_print_srat_entry() and acpi_table_parse_srat() are only > referenced within drivers/acpi/numa.c, so we can mark them as static and > remove their prototypes from the header file. > > Likewise, pxm_to_node_map[] and node_to_pxm_map[] are only used within > drivers/acpi/numa.c, so we mark them as static and remove their externs > from the header file. > > The automatic 'result' variable is unused in acpi_numa_init(), so it's > removed. > > Signed-off-by: David Rientjes <rientjes@google.com> > Signed-off-by: Andi Kleen <ak@suse.de> > > --- > arch/x86_64/mm/srat.c | 6 +++--- > drivers/acpi/numa.c | 20 ++++++++++---------- > include/linux/acpi.h | 2 -- > 3 files changed, 13 insertions(+), 15 deletions(-) > > Index: linux/arch/x86_64/mm/srat.c > =================================================================== > --- linux.orig/arch/x86_64/mm/srat.c > +++ linux/arch/x86_64/mm/srat.c > /* maps to convert between proximity domain and logical node ID */ > -static int pxm_to_node_map[MAX_PXM_DOMAINS] > +static int __cpuinitdata pxm_to_node_map[MAX_PXM_DOMAINS] > = { [0 ... MAX_PXM_DOMAINS - 1] = NID_INVAL }; > -static int node_to_pxm_map[MAX_NUMNODES] > +static int __cpuinitdata node_to_pxm_map[MAX_NUMNODES] > = { [0 ... MAX_NUMNODES - 1] = PXM_INVAL }; > do we need to put __initdata just before =?
YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|